Fixups - Githubissues

preaction / Yancy

The Best Web Framework Deserves the Best Content Management System

http://preaction.me/yancy/

Other

54 stars 21 forks source link

Fixups #59

Closed mohawk2 closed 5 years ago

mohawk2 commented 5 years ago

These are further minor fixups on the path to having "relations" work.

This closes #48.

coveralls commented 5 years ago

Coverage increased (+0.2%) to 99.541% when pulling 1fdf5ea22b5485461f180c846f4a0e8ead051322 on mohawk2:fixups into 9e7aeced130749c392ce8e24586c662bde93458e on preaction:master.

mohawk2 commented 5 years ago

Notable changes in the last few commits:

unify tests to all use %Yancy::Backend::Test::SCHEMA - rationale is that all the tests need to work with real backends, and this exposes any failure
now if there is a single unique column that is not a PK (which I gather is called a "natural" key, like an SSN), x-id-field will be set to that over a "surrogate" (normal relational ID) integer one

mohawk2 commented 5 years ago

I've made the backend tests apply exactly the same tests to the mock one, which needed a bit of tweaking. I also added @rmallah's idea (in #49) of handling list for boolean in the backends, and adjusted his commit to then use that, which you can see is now included!