git checkout fails when switching to base commit

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.

https://github.com/marketplace/actions/compressed-size-action

MIT License

602 stars 84 forks source link

git checkout fails when switching to base commit #17

Closed schliflo closed 4 years ago

schliflo commented 4 years ago

I am getting the following error:

Screenshot 2020-03-13 at 20 41 24

A possible fix probably is using git reset --hard ${baseRef} instead of git checkout ${baseRef} here: https://github.com/preactjs/compressed-size-action/blob/9754acd0ee298ba98deebeed0f8a0eae25e0f356/action.js#L91

Is there a way for me to easily test this fix without publishing my own fork as an action? I'd be happy to create a PR, but I don't see a way to test this properly...

developit commented 4 years ago

Testing Github Actions is pretty much a manual process at this point. If you could PR that change, I'll test it out locally and verify. It seems like a very reasonable and safe change, since the container filesystem isn't persisted anywhere.

schliflo commented 4 years ago

Sure, I'll get right to it.