search

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.
https://github.com/marketplace/actions/compressed-size-action
MIT License
602 stars 84 forks source link

Document missing inputs? #27

Closed brandonweiss closed 4 years ago

brandonweiss commented 4 years ago

Hey! I was reading through the README and couldn’t quite figure out how this action worked… there didn’t seem to be any configuration about where to look for the output of the build. I thought maybe it automagically figured it out by only comparing untracked file (not checked in to Git) Then I read through the source and found there are pattern and exclude inputs.

Is there a reason those aren’t documented in action.yml and the README? 🤔

brandonweiss commented 4 years ago

Actually after testing it out it seems I can’t use the pattern or exclude inputs because they’re not defined in the action.yml 🤔 Does that mean this action can’t be used unless your bundle happens to be located in a “dist” folder?

brandonweiss commented 4 years ago

Oh, I just discovered #24 🤦‍♂️

developit commented 4 years ago

Fixed in the latest v2 (v2.0.1)!