search

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.
https://github.com/marketplace/actions/compressed-size-action
MIT License
602 stars 84 forks source link

total size 0B? #3

Closed FezVrasta closed 4 years ago

FezVrasta commented 4 years ago

Hi, I'm trying to integrate this in my repo, but the report reports 0 bytes.

Do I have to specify the dist files somehow?

Test PR here: https://github.com/popperjs/popper-core/pull/975

FezVrasta commented 4 years ago

Ok, nevermind, I needed to specify the pattern parameter:

name: Compressed Size

on: [pull_request]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2-beta
        with:
          fetch-depth: 1
      - uses: preactjs/compressed-size-action@v1
        with:
          repo-token: '${{ secrets.GITHUB_TOKEN }}'
          pattern: 'dist/umd/*.js'
developit commented 4 years ago

Heh - you must have closed this fast enough that I didn't see! Apologies for not responding.