Closed JoviDeCroock closed 4 months ago
Latest commit: a28dc054a7d2fa615e3f059b1d3617576e969816
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | a28dc054a7d2fa615e3f059b1d3617576e969816 |
Latest deploy log | https://app.netlify.com/sites/preact-signals-demo/deploys/66911a07360fa40008b40a0d |
Deploy Preview | https://deploy-preview-584--preact-signals-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Size Change: +348 B (+0.43%)
Total Size: 81.4 kB
Filename | Size | Change |
---|---|---|
packages/react-transform/dist/signals-*********.js |
5.03 kB | +122 B (+2.49%) |
packages/react-transform/dist/signals-transform.mjs |
4.27 kB | +103 B (+2.47%) |
packages/react-transform/dist/signals-transform.umd.js |
5.15 kB | +123 B (+2.45%) |
LGTM, but a test case would be nice
@marvinhagemeister good shout, was still figuring out how to trick the isModule
helper đ
Any progress with this PR? I started a new React Native App, and would love to give it a try to signals
Noticed we threw an error for non-ESM modules, so added support for that as we are exporting a CJS build of our react-bindings either way.
CC @andrewiggins not sure if you opted out here for a reason
Fixes https://github.com/preactjs/signals/issues/575