preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.81k stars 95 forks source link

feat(react-transform): Suppport require syntax in our babel transform #584

Closed JoviDeCroock closed 4 months ago

JoviDeCroock commented 4 months ago

Noticed we threw an error for non-ESM modules, so added support for that as we are exporting a CJS build of our react-bindings either way.

CC @andrewiggins not sure if you opted out here for a reason

Fixes https://github.com/preactjs/signals/issues/575

changeset-bot[bot] commented 4 months ago

đŸĻ‹ Changeset detected

Latest commit: a28dc054a7d2fa615e3f059b1d3617576e969816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------- | ----- | | @preact/signals-react-transform | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit a28dc054a7d2fa615e3f059b1d3617576e969816
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/66911a07360fa40008b40a0d
Deploy Preview https://deploy-preview-584--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

Size Change: +348 B (+0.43%)

Total Size: 81.4 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 5.03 kB +122 B (+2.49%)
packages/react-transform/dist/signals-transform.mjs 4.27 kB +103 B (+2.47%)
packages/react-transform/dist/signals-transform.umd.js 5.15 kB +123 B (+2.45%)
ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `docs/dist/assets/client.********.js` | 46.3 kB | | `docs/dist/assets/index.********.js` | 838 B | | `docs/dist/assets/jsxRuntime.module.********.js` | 284 B | | `docs/dist/assets/preact.module.********.js` | 4.03 kB | | `docs/dist/assets/signals-core.module.********.js` | 1.4 kB | | `docs/dist/assets/signals.module.********.js` | 2.02 kB | | `docs/dist/assets/style.********.js` | 21 B | | `docs/dist/assets/style.********.css` | 1.21 kB | | `docs/dist/basic-********.js` | 244 B | | `docs/dist/demos-********.js` | 3.41 kB | | `docs/dist/nesting-********.js` | 1.13 kB | | `docs/dist/react-********.js` | 242 B | | `packages/core/dist/signals-core.js` | 1.45 kB | | `packages/core/dist/signals-core.mjs` | 1.47 kB | | `packages/preact/dist/signals.js` | 1.27 kB | | `packages/preact/dist/signals.mjs` | 1.22 kB | | `packages/react/dist/signals.js` | 188 B | | `packages/react/dist/signals.mjs` | 150 B |

compressed-size-action

marvinhagemeister commented 4 months ago

LGTM, but a test case would be nice

JoviDeCroock commented 4 months ago

@marvinhagemeister good shout, was still figuring out how to trick the isModule helper 😅

alxrodav commented 4 months ago

Any progress with this PR? I started a new React Native App, and would love to give it a try to signals