search

prebid / line-item-manager

Prebid Line Item Management Tool
Other
31 stars 17 forks source link

SafeFrame property in YAML being ignored by GAM #119

Closed timbolimboslice closed 1 year ago

timbolimboslice commented 2 years ago

Description

I'm trying to create line items with creatives that do not serve in a SafeFrame. I'm setting the safe_frame under creative > banner to false. When I do a test run, the creatives that are created still have "Serve into a SafeFrame" checked off.

What I Did

I ran this command with the attached YAML file: line_item_manager create txmo_config-updated.yml -b teads -t

YAML File

GAM Screenshot

torontobros commented 2 years ago

Hey Tim

YAML files are case sensitive and input a lower case “false” as value

Cheers Dan

On Oct 14, 2022, at 12:33 PM, Tim Biery @.***> wrote:

 line-item-manager version: 0.2.9 Python version: 3.9 Operating System: macOS Monterey, 12.6 Description

I'm trying to create line items with creatives that do not serve in a SafeFrame. I'm setting the safe_frame under creative > banner to false. When I do a test run, the creatives that are created still have "Serve into a SafeFrame" checked off.

What I Did

I ran this command with the attached YAML file: line_item_manager create txmo_config-updated.yml -b teads -t

YAML File

GAM Screenshot

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

timbolimboslice commented 2 years ago

I did try both false and False with the same results.

torontobros commented 2 years ago

I ran your yaml file on my machine and it worked ok with Safeframe unchecked. Are you sure you're inspecting the correct creative?

dshore commented 2 years ago

FYI, false or False are interpreted the same by python PyYAML package used by the tool

Egge21M commented 1 year ago

I just ran into the same issue. I know its been a while, has somebody found a fix for this?

Egge21M commented 1 year ago

NVM, I found my issue and I would suspect that this is acutally what caused the problem for @timbolimboslice as well. If there already is a creative mathing name or ID in your config file, it will use that creative for all line items (if there already is a creative present that has SafeFrame turned on, this script will not replace or update that creative).

Easy fix: Change the creative name to create a new one