prebid / professor-prebid

Prebid's next-gen debugging tool
Apache License 2.0
20 stars 17 forks source link

Request: Let user define prebid name that extension should look for #90

Closed mukero320 closed 1 month ago

mukero320 commented 2 months ago

As in this issue https://github.com/prebid/professor-prebid/issues/82

It would be lovely to use this extension on any website, not just those that have default pbjs naming scheme. Let use define the name that he is looking for in window._"definedName"Globals

florianerl commented 2 months ago

Hi @mukero320 ,

just for my understanding: why would anyone change the name of window._pbjsGlobals?

mukero320 commented 2 months ago

From my understanding It's neccesary to avoid issues with 2 prebid instances on 1 page https://docs.prebid.org/dev-docs/faq.html#can-i-run-multiple-different-versions-of-prebidjs-concurrently

On Thu, Apr 18, 2024 at 2:19 PM Florian Erl @.***> wrote:

just for my understanding: why would anyone change the name of window._pbjsGlobals?

— Reply to this email directly, view it on GitHub https://github.com/prebid/professor-prebid/issues/90#issuecomment-2063733885, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ6HXMOGV2427TNTGPK2F5TY5624NAVCNFSM6AAAAABGNADVR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTG4ZTGOBYGU . You are receiving this because you authored the thread.Message ID: @.***>

florianerl commented 2 months ago

Hi,

if you change the global var name as described, it shouldn't change the "window.pbjsGlobals" variable. If you change your var name to let's say "genesisAds", then "window.pbjsGlobals" should be an array containing "genesisAds" (plus any other var names that other prebid instances might use).

like this page is using 3 different instances: image