search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Build `latest` docker container from master not `develop` branch #161

Closed valentin-seitz closed 1 year ago

valentin-seitz commented 1 year ago

Should fix #160 Here a similar idea to the python-bindings applies: I Made the Workflow a bit more usable via the manual dispatch and also split up latest and develop tags accordingly.

Additionally the Dockerfile is more in line with the current approach to Dockerfiles used in the Systemtestsv2

valentin-seitz commented 1 year ago

I dont know about the checks: The Linting complains about missing links. So for me it seems that its not related to this PR.

IshaanDesai commented 1 year ago

Similar to the question in the Python bindings. Do we really need to merge to master? We only merge to master via a release, so we would need to discuss such a merge before.

valentin-seitz commented 1 year ago

I just created the merge to master because the the workflows that are "normally" triggered are the ones available on master. But this could go to develop when the workflow is not started now from master and therefore overriding the image with thelatest tag again .

MakisH commented 1 year ago

I understand that there is no reason (anymore) to target master, so let's just change the target branch to develop and merge.

@valentin-seitz you can change the target branch by clicking "Edit" on the top.

IshaanDesai commented 1 year ago

I pointed the PR to develop. It is still draft, but is this ready for review and merging?

valentin-seitz commented 1 year ago

I pointed the PR to develop. It is still draft, but is this ready for review and merging?

This is indeed ready for merging. Note that similar to the python-bindings, this change will not be effective until its merged to master.

IshaanDesai commented 1 year ago

Note that similar to the python-bindings, this change will not be effective until its merged to master.

Do we need this to be effective before version 3 of all downstream packages are released?

valentin-seitz commented 1 year ago

Note that similar to the python-bindings, this change will not be effective until its merged to master.

Do we need this to be effective before version 3 of all downstream packages are released?

From my perspective: not really. I currently rely on the latest tag to be compatible with v2 but i can easily re trigger the publishing of the image with the latest tag manually

MakisH commented 1 year ago

We don't need to update master, but I guess we can already merge this, right? If yes, @IshaanDesai I leave it up to you.