precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Tests checking implementation of checkpointing/SolverState #173

Closed NiklasVin closed 3 months ago

NiklasVin commented 3 months ago

These tests are written in context of Pull Request https://github.com/precice/fenics-adapter/pull/172 Since the core functionality of the checkpointing is implemented in the SolverState class, the tests are actually testing only this class. This commit consists of three different tests:

  1. Write checkpoint & directly load it (just for the sake of completeness)
  2. Write checkpoint of a function, then modify the dof vector of the dolfin function by directly accessing it via vector(). After that, load the checkpoint.
  3. Write checkpoint of a function, then modify the this dolfin function via assign(). After that, load the checkpoint.
BenjaminRodenberg commented 3 months ago

To make sure: At the moment we expect this test to fail. As soon as https://github.com/precice/fenics-adapter/pull/172 is merged this test should succeed. Correct?

NiklasVin commented 3 months ago

To make sure: At the moment we expect this test to fail. As soon as #172 is merged this test should succeed. Correct?

Yes

BenjaminRodenberg commented 3 months ago

Ok. Then I will merge the tests soon. This leads to failure on develop but then we have #172 as a fix already prepared.