Open arvedes opened 2 years ago
This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:
https://precice.discourse.group/t/problem-with-rbf-interpolation-in-the-fenics-x-adapter/1037/7
Another idea: There is actually PyRBF
, which also comes from the "preCICE bubble". If we use this package, we could make sure that the RBF interpolation performed in the adapter is consistent with the interpolation performed in preCICE. I'll try to evaluate this option with @IshaanDesai and @KyleDavisSA.
Note: The most recent and actively maintained version is Kyle's fork: https://github.com/KyleDavisSA/PyRBF
Using PyRBF is a really good idea here, as it would lead to having a choice between several integration schemes. The major work package I see here is to convert PyRBF into a library if that is not already the case.
The default rbf-iterpolation https://github.com/precice/fenicsx-adapter/blob/6db7f454330433ad745a8e08a0cd122937b5474e/fenicsxprecice/expression_core.py#L157 currently used in the adapter may lead to issues for some cases, see e.g. https://precice.discourse.group/t/problem-with-rbf-interpolation-in-the-fenics-x-adapter/1037. We should provide an option to configure the rbf parameters.