predict-idlab / powershap

A power-full Shapley feature selection method.
Other
193 stars 18 forks source link

Correct use of random_state for xgboost #37

Closed lorenjan closed 1 year ago

lorenjan commented 1 year ago

The seed parameter in xgboost was changed to "random_state" to match sklearn's API. This fix corrects the random state behavior and silences a warning which prints on every iteration.

codecov-commenter commented 1 year ago

Codecov Report

Merging #37 (7847432) into main (6e17ae0) will not change coverage. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files           6        6           
  Lines         372      372           
=======================================
  Hits          312      312           
  Misses         60       60           
Impacted Files Coverage Δ
powershap/shap_wrappers/shap_explainer.py 96.79% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jvdd commented 1 year ago

Thx for submitting this clear PR @lorenjan

Always pleased to see the community contribute!! :handshake: