search

premailer / css_parser

Ruby CSS Parser
Other
279 stars 110 forks source link

Changes to creation of rule set #154

Closed stoivo closed 3 months ago

stoivo commented 3 months ago

I am working on solving #128. To get to know the code I did some changed which I think makes it overall better.

I could try not to change anything else that what I absolutely have to but I think we will come better out of it if we make some more changes. Could you take a look at this changes and give me some pointer if you like this or not?

grosser commented 3 months ago

rubocop failed

stoivo commented 3 months ago

I think we can patch 1.x to have deprecation for changed to public API, and create update v2 branch without those. Probably a good idea to change to version 2 when we replace the css parser

grosser commented 3 months ago

I'm not a fan of deprecations and the extra complexity they bring, but this looks most well though out to me so 👍