search

premailer / css_parser

Ruby CSS Parser
Other
279 stars 110 forks source link

V2 rule set declaration parsing #159

Closed stoivo closed 2 months ago

stoivo commented 3 months ago

I refactored expand_font_shorthand. I think its better. I think I want to do the same for all the other expand features. When I do that I think we can remove more of the regexes. Would you like that?

I am trying not to touch test too much to keep all existing features working.

Should I maybe add some notes into changelog that some features are removed?

stoivo commented 3 months ago

I need to investigate what happening here, never worked with Jruby before

stoivo commented 2 months ago

I don't know whats the matter with Jruby. Now it works with no change. Could be network issue Screenshot 2024-06-03 at 11 14 42

Not you are running jruby-head(think this is master branch) I think you want jruby(latest release)?

stoivo commented 2 months ago

I think we can merge this