search

premailer / css_parser

Ruby CSS Parser
Other
279 stars 110 forks source link

Fix selectors :not(.a,.b) #161

Closed stoivo closed 2 months ago

stoivo commented 3 months ago

Fix #160

Why and what is being done.

Pre-Merge Checklist

stoivo commented 2 months ago

rebased on v2-rule-set-declaration-parsing

stoivo commented 2 months ago

Jruby is failing because of a bug in jruby https://github.com/jruby/jruby/issues/8283

@grosser Can we set jruby to be allowed to fail?

grosser commented 2 months ago

yeah sure 👍

grosser commented 2 months ago

best link to to bug next to the allow-fail

stoivo commented 2 months ago

actually it, headius fixed it yesterday https://github.com/jruby/jruby/issues/8283

stoivo commented 2 months ago

lets give it a couple of days and see if jruby-head fixes itself

stoivo commented 2 months ago

Yay, jruby is working again.

stoivo commented 2 months ago

Time to merge

grosser commented 2 months ago

awesome :D