[Android Bootcamp] Twitter Client Code Review

[preraktrivedi]

Hello,

Please review my Twitter Client assignment for week 3. I've added a sample apk and screenshots in the folder "sampleapk". Also updated the README.md with screenshots and features for the app. I've also included the libraries to import that are required for this project to work (PullToRefresh and support-v7-appcompat).

Hours Spent:

Spent about 20-25 hours over all to get all the features working and make the app as bug free as possible.

Required User stories completed:

-User can sign in using OAuth login flow -User can view last 25 tweets from their home timeline

• - User should be able to see the user, body and timestamp for tweet
• - User should be displayed the relative timestamp for a tweet "8m", "7h"
  • User can load more tweets once they reach the bottom of the list using "infinite scroll" pagination
  • User can compose a new tweet:
  • - User can click a “Compose” icon in the Action Bar on the top right
  • - User will have a Compose view opened
  • - User can enter a message and hit a button to post to twitter
  • - User should be taken back to home timeline with new tweet visible

Optional User stories completed:

• Improve the user interface and theme the app to feel twitter branded
• Links in tweets are clickable and viewable
• User can see a counter with total number of characters left for tweet on Compose Activity
• User can refresh tweets timeline by pulling down to refresh
• User can tap a tweet to display a "detailed" view of that tweet.
• User can select "reply" from detail view to respond to a tweet
• Stretch : User can see an embedded media (image) within tweet detail view
• Additionally : User can see an embedded media (image) in tweet timeline as well
• Additionally : User can swipe left or right to hide the tweet temporarily
• Additionally : Swing in animations added for making it more beautiful.

Devices/Emulator tested on:

-Google Nexus 5 -Samsung Galaxy S4 -Genymotion Nexus 5 image

Thanks, Prerak

/cc @nesquena @timothy1ee

[nesquena]

Want to make a special note here since you submitted an excellent project, implementing many of the optionals. I fully understand and appreciate that most everyone in this class has full-time work and many other obligations in their lives, which makes those who are able to submit polished versions by the deadline earn my respect that much more. Really hope you found this project to be a great learning experience. If you enjoy this class at the end and you believe in what we are doing with CodePath, I'd love to chat with you about ways you can act as mentor, help with our community efforts or even act as a (paid) instructor in the future.

A few notes after checking out the code:

• Nice use of ViewHolder pattern for your adapter!
• Good to see you were able to format the timestamp cleanly
• Nice to see you used a PullToRefresh library for easy timeline refreshes
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being calculated for Compose
• Great job with the detail view
• Consider removing BaseModel from Tweet and User and follow this json to model approach instead which doesn't require BaseModel
• Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[preraktrivedi]

Hey Nathan,

Thanks a lot for the kind words. It's been a great experience developing all these apps in such short time. Challenging but fun at the same time. The cliffnotes are of a great help!

I would love to learn more about the mentor/instructor opportunities and hopefully able to contribute to the community. Thanks for all your help as well.

See you in evening.

-Prerak

cc @nesquena