search

preservim / vim-colors-pencil

Light (& dark) color scheme inspired by iA Writer
Other
606 stars 73 forks source link

Support for tree-sitter? #33

Open lourenci opened 4 years ago

lourenci commented 4 years ago

The title speaks for itself.

Thank you for the colorscheme, I think it's the best light one out there.

daliusd commented 4 years ago

I looked around a little bit. What tree-sitter has to do with colorscheme? Do you have any example of colorscheme that supports tree-sitter?

daliusd commented 4 years ago

OK I found one. If you are using tree sitter you can test this color scheme with similar change to this one https://github.com/Iron-E/nvim-highlite/commit/8c0162d4ddd4c2d796d52eefb380ace3bc96dcb6 and create PR.

lourenci commented 4 years ago

The colorschemes could leverage the treesitter to keep the colors consistency between the groups, take a look at this. Not to mention that we could ditch polyglot, yats... plugins.

There are already some colors using it.

daliusd commented 4 years ago

That's fine. If you are using treesitter you are the best person to add support to it ;-)

lourenci commented 4 years ago

I'll try it.

alerque commented 4 years ago

I'd be happy to facilitate inclusion of a PR that adds whatever group aliasing is needed for tree-sitter support.It does seem kind of backwards though to generate a bunch of non-standard group names and expect color schemes to adapt. Wouldn't it make more sense to have a tree-sitter option to just alias all the groups to standard names that every color scheme out there already supports?

daliusd commented 4 years ago

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

lourenci commented 4 years ago

Honestly, my impression is that tree-sitter is doing exactly and many colorschemes just work with it. But it is possible that not all options are covered by standard names and some settings must be added.

You hit the nail on the head. :)

alerque commented 4 years ago

If that's what's going on, then fair enough. Like I said I'm quite happy to see it facilitated from the color scheme end if that's what needs to happen, and if somebody contributes the leg work to figure out the right groups to add I'll help get it merged.