search

pressel / pycles

A python based infrastructure for cloud large eddy simulation.
GNU General Public License v3.0
92 stars 69 forks source link

Update Simulation3d.pyx #38

Open sally-xiyue opened 6 years ago

sally-xiyue commented 6 years ago

Fixed when Surface Init is called to be compatible for the Arctic cases.

cmkaul commented 6 years ago

It needs to be checked that moving Surface.initialize after the restart files are read does not mess up other cases (in particular, those that use a surface energy budget so that T_surface is read from the restart files). It should suffice to check that all cases that set T_surface to a prescribed initial value do so in the init function rather than in initialize...

In general, it is important to be really careful when changing the order of calls in Simulation3d.pyx! All cases need to be checked for compatibility not just whichever are currently being added/edited.

cmkaul commented 6 years ago

Sally's comment is "Fixed when Surface update is called to be compatible for the Arctic cases." but I only see where Surface.initialize has been moved...am I missing something?

sally-xiyue commented 6 years ago

Sorry, I meant Initialization. My bad, I'll fix the description!