pret / pokeruby

Decompilation of Pokémon Ruby/Sapphire
799 stars 225 forks source link

English Debug menu translations! #757

Closed easyaspi314 closed 5 years ago

easyaspi314 commented 5 years ago

I'm back!

                       す
Éß テ-ブ↑& ÒÛªù! (かなテーブルを捨てろよ!/Throw away the kana table!)

When compiled in English with DEBUG, instead of óじばÌ (mojibake), you now get actual English translations!

No more switching from the game, to the kana chart, and if you don't know Japanese, Google Translate, just to read one sentence.

Additionally, the few unknown translations should use proper encoding or Romaji.

I decided to use a nicer macro system:

static const u8 sStrHello[] = DTR("こんにちは", "Hello");

This prevents ifdef HELL, as the mixed Japanese and English would be messy.

Additionally, some special character issues were corrected.

Things untranslated/bugs:

~~I also made it so this will compile with the system preprocessor (including Clang), and my agbcc binutils (which will attempt to be selected automatically if you don't have DKP).

Clang needs a few flags (it can't do asm enums with line numbers and it does trigraphs in standard mode), but it is no longer flipping out.~~

I am going to restart my build system project. It was getting way off track, and ucpp was too difficult to maintain (one of the main reasons for the silence).

easyaspi314 commented 5 years ago

Also, props to TCRF, Jisho, and Google Translate. It got the bulk of the translations. :P

easyaspi314 commented 5 years ago

I think this is ready, it's not perfect, but it is pretty damn awesome.

easyaspi314 commented 5 years ago

(for the reference, yes, I fixed the WIP thing)

PikalaxALT commented 5 years ago

@easyaspi314 Please resolve merge conflicts.