prettier / prettier-eslint-cli

CLI for prettier-eslint
https://npm.im/prettier-eslint-cli
MIT License
539 stars 85 forks source link

feat!: bump all upgradable (dev)Dependencies except pure ESM #437

Closed JounQin closed 2 years ago

JounQin commented 2 years ago

close

What:

Maintenance

Why:

The (dev)Dependencies are very outdated

How:

  1. Bump all upgradable (dev)Dependencies except pure ESM ones
  2. Upgrade GitHub Actions versions and related usage
  3. Enable CI workflow for pull_request events
  4. Replace husky with simple-git-hooks which is much easier to use, you may need to run git config --unset core.hooksPath if you've enabled husky@v2+ previously
  5. Remove cli-test task (which is buggy) in favor of test including cli.spec already, now npm start validate is just working as expected
  6. Use eslint-plugin-node-dependencies to ensure we have correct versions range of dependencies
  7. Enable CodeSandbox CI for testing before releasing easily

I will start to migrate to pure ESM later

codecov-commenter commented 2 years ago

Codecov Report

Merging #437 (eb8e934) into master (04a8e04) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          157       161    +4     
  Branches        23        27    +4     
=========================================
+ Hits           157       161    +4     
Impacted Files Coverage Δ
src/format-files.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JounQin commented 2 years ago

@kylemh @lydell

Don you have permissions to install GitHub Apps on this repository? I'd like to install https://ci.codesandbox.io to address https://github.com/prettier/prettier-eslint-cli/pull/424#issuecomment-1200525921

kylemh commented 2 years ago

Go for it. We're all in charge here.

JounQin commented 2 years ago

Go for it. We're all in charge here.

Did you receive my request? I sent it a few days ago and just send the request again.

lydell commented 2 years ago

I don’t have access. I have very few permissions in the repo, it looks like.

JounQin commented 2 years ago

cc @prettier/core

fisker commented 2 years ago

image image

Is this what you need?

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 7.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: