primefaces / primereact

The Most Complete React UI Component Library
https://primereact.org
MIT License
6.68k stars 1.01k forks source link

Sidebar: onHide - closing on peripheral actions #2652

Closed getdir closed 2 years ago

getdir commented 2 years ago

[x] bug report

Can be seen in demos: https://www.primefaces.org/freya-react/#/

Component: Sidebar.

Documentation: onHide - Callback to invoke when the actions used to close the sidebar are triggered. Exp; close icon, mask and esc key.

Documentation reads as the intended clicks of these actions will close the sidebar. Another exists: highlighting text within the sidebar and having the cursor over the mask when releasing the trigger to highlight text (clicking inside Sidebar and holding mouse to highlight, cursor going over into mask, releasing on mask, renders a closed sidebar).

Can be seem in sidebar provided in this theme: https://www.primefaces.org/freya-react/#/

I think the use case is self explanatory and recognized as significant use cases if they are used to demonstrate capabilities in the theme itself.

Expected behavior: Ability to highlight text or some other intuitive action... independent from Sidebar state, regardless of where highlight trigger terminates. Documentation shows the intent of triggers to close Sidebar are explicit actions, not abstracted ones from other intentions/normal behavior.

classnames: ^2.3.1, fullcalendar: ^5.10.2, primeflex: ^3.1.2, primeicons: ^5.0.0, primereact: ^7.2.0, react: ^17.0.2, react-dom: ^17.0.2, react-router: ^6.2.1, react-router-dom: ^6.2.1, react-scripts: 5.0.0, react-transition-group: ^4.4.2, sass: ^1.49.7, web-vitals: ^2.1.4, wretch: ^1.7.9

Chrome Version 98.0.4758.102 (Official Build) (x86_64) MacOS 10.15.7 (19H15) VSCode Version: 1.64.2

All languages.

melloware commented 2 years ago

Thanks for your report. PR Submitted.