primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Use dimension/px transformer instead of custom #736

Closed lukasoppermann closed 2 months ago

lukasoppermann commented 2 months ago

Summary

Replace custom transform with upstream equivalent

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 2029a72e4bcf1b926876e6e308fe5f853debd580

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/brand-primitives | Patch | | @primer/react-brand | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

🔍 Design token changes found

View CSS variable changes ```diff - --brand-VideoPlayer-tooltip-padding: 0.3125rem; + --brand-VideoPlayer-tooltip-padding-inline: 0.3125rem; ``` ```diff + --brand-VideoPlayer-tooltip-padding-block: 0.3125rem; ```
github-actions[bot] commented 2 months ago

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.