Closed primer-css closed 2 months ago
Please ensure these items are checked before merging.
github/github
, as a primary consumer of Primer Brand
bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION}
Important: Verify that each workspace package has been updated correctly in their respective package.json
files/features/copilot
/enterprise
/enterprise/advanced-security
/articles/security
/articles/security/what-is-security-testing
/features/preview
/features/copilot/getting-started
and /features/copilot
/solutions/devops
/education
/mobile
/contact-sales
/about/diversity
Performed successful integration test with githubuniverse.com
, as a Tier 1 consumer of Primer Brand outside of the monolith.
Performed successful integration test with https://resources.github.com/
, as a Tier 1 consumer of Primer Brand outside of the monolith.
[x] Add report summary of your findings, including any images. Use following template as a guide:
#### Smoke test results
- Feature 1 π’ π‘ π΄ (choose one, depending on success levels)
{insert screenshot}
Release testing status: Ready to release π’ | Paused π‘ π΄ (choose one and provide reason)
primer brand
Slack channelOur visual comparison tests did not find any differences in the UI.
display: inline-block;
from animated Card component π’<b>
elements by default π’--brand-VideoPlayer-tooltip-padding
design token in the VideoPlayer
component π’No regressions found during testing by @danielguillan and @joshfarrant.
Release testing status: Ready to release π’
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@primer/brand-primitives@0.40.1
Patch Changes
#736
73cf706e
Thanks @lukasoppermann! - Replaced the--brand-VideoPlayer-tooltip-padding
design token in theVideoPlayer
component with two new tokens that separately account for padding along each axis:--brand-VideoPlayer-tooltip-padding-inline
and--brand-VideoPlayer-tooltip-padding-block
.Note: This update does not introduce any visual changes. Please update any manual references to
--brand-VideoPlayer-tooltip-padding
to use the new tokens.#738
f6bab573
Thanks @lukasoppermann! - Fixed line formatting infunctional/size/size-coarse.css
andfunctional/size/size-fine.css
E.g.
@primer/react-brand@0.40.1
Patch Changes
#754
d061705c
Thanks @joshfarrant! - TheRiverStoryScroll
component now enforces that its children must beRiver
components through type checking, instead of relying on a run-time check.#739
24bd6338
Thanks @joshfarrant! - Fixed a bug in theSubNav
component where the submenu toggle was rendered as an empty button on mobile viewports.#736
73cf706e
Thanks @lukasoppermann! - Replaced the--brand-VideoPlayer-tooltip-padding
design token in theVideoPlayer
component with two new tokens that separately account for padding along each axis:--brand-VideoPlayer-tooltip-padding-inline
and--brand-VideoPlayer-tooltip-padding-block
.Note: This update does not introduce any visual changes. Please update any manual references to
--brand-VideoPlayer-tooltip-padding
to use the new tokens.#722
99328ce0
Thanks @danielguillan! - Added support for<b>
elements toBento
,RiverBreakout
,SectionIntro
,Timeline
, andTestimonial
components, as<em>
is semantically interpreted by screen readers for emphasis, while<b>
allows duo-tone text to function purely as a visual decoration.Usage example:
#733
2dcb9bad
Thanks @danielguillan! - Fixes Label component multiline reflow#746
4af8db14
Thanks @joshfarrant! - Fixed a bug whereCard
components rendered within a dark colour mode would not take the full width of their container.@primer/brand-storybook@0.40.1
@primer/brand-e2e@0.40.1
@primer/brand-fonts@0.40.1
@primer/brand-config@0.40.1