primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Fix riverstoryscroll on narrow viewports #797

Closed rezrah closed 1 month ago

rezrah commented 1 month ago

Summary

Fixes RiverStoryScroll on narrow viewports.

Previously didn't render the layout correctly at all on various browsers, due to incorrect CSS nesting.

Fixed by cleaning up the CSS file

Tested working in Next.js in Chrome 👇

https://github.com/user-attachments/assets/00afcd3c-03d7-4be5-8579-22616d4d5e6d

List of notable changes:

What should reviewers focus on?

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

Screenshots:

Please try to provide before and after screenshots or videos

Before After
![Screenshot 2024-10-24 at 11 41 05](https://github.com/user-attachments/assets/04686395-da31-48f8-8672-4c5f423abd41) ![Screenshot 2024-10-24 at 11 51 21](https://github.com/user-attachments/assets/aca9e22c-166c-4f39-b65a-fde37cd7317a)
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 5c49d8b688bae2483367c1ce40a067c76ab4a16b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/react-brand | Patch | | @primer/brand-primitives | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🟢 No design token changes found

github-actions[bot] commented 1 month ago

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.