search

primer / css

Primer is GitHub's design system. This is the CSS implementation
https://primer.style/css
MIT License
12.57k stars 1.22k forks source link

Import CSS files directly into Sass #2727

Closed kawakamimoeki closed 2 weeks ago

kawakamimoeki commented 1 month ago

What are you trying to accomplish?

Fixed a bug that prevented package users from resolving CSS paths in @primer/primitives when trying to import @primer/css/color-modes.

What approach did you choose and why?

Removed .css extension from @import and modified @primer/primitives to be output as Sass code.

What should reviewers focus on?

Please review that this approach is reasonable.

Can these changes ship as is?

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 2ddc498b760d715e1edf1b8719b1f46f87ce3fec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | @primer/css | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR