search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.34k stars 829 forks source link

[Bug] `@primer/octicons-react` includes raw SVG files, but are inaccessible #998

Closed fregante closed 8 months ago

fregante commented 11 months ago

Describe the bug

The @primer/octicons-react package includes the raw SVGs:

https://www.unpkg.com/browse/@primer/octicons-react@19.8.0/build/

but they're not accessible because exports map blocks its access:

https://github.com/primer/octicons/blob/6bc78de32be1a218a69e10a731072331ba94e7f9/lib/octicons_react/package.json#L10-L14

Expected behavior

I don’t think they're useful in this package, so they should probably just be removed.

joshblack commented 8 months ago

I believe this was closed by #1009, sorry again about my mistake with merging @fregante!