prinzstani / CookieBot

Automatic Playthrough for Cookie Clicker
GNU General Public License v3.0
51 stars 34 forks source link

[Steam?] Unreadable Numbers #77

Closed Kikithecat12345 closed 2 years ago

Kikithecat12345 commented 2 years ago

image The above screenshot shows a completely useless number to the user. Can we make it show something like 1.000 novemdecillion or something? EDIT: Forgot to mention: this text shows up when hovering over the version of the bot, and in the notifications at the bottom of the page.

prinzstani commented 2 years ago

This screenshot puzzles me. I do not get this message, for me, it looks like Trying to get achievement: Bake 100 nonillion cookies in one ascension.

I am not sure why you get this huge number. Did you deactivate short numbers? I have tried to deactivate short numbers, but it still shows the short numbers in the notification. Then I restarted the game, and now I get Trying to get achievement: Bake 1.00e+32 cookies in one ascension.

So in short, it looks to me that the appearance of this note can be influenced by the normal cookie clicker options, even though I do not know which option you have used to get the result you showed.

Kikithecat12345 commented 2 years ago

Odd, it could be an issue with the Steam version. I'll update the name of this issue then.

pie3636 commented 2 years ago

I can confirm having the same issue (on Steam). image

Short numbers is enabled in options, and I don't believe I have changed any other setting.

prinzstani commented 2 years ago

That is odd. We use the original cookie clicker description of the achievement. In my version, I have a difference between desc and baseDesc, for example Game.AchievementsById[279].desc 'Bake 100 undecillion cookies in one ascension.' Game.AchievementsById[279].baseDesc 'Bake 100000000000000000000000000000000000000 cookies in one ascension.'

The bot uses the desc, which here is the correct one. Could you check how this unfolds on Steam?

Moreover, what is the description that you see in the note when you finally get the achievement? What is the description that you see when you hover over the achievement when you finally have it?

Kikithecat12345 commented 2 years ago

I can check this when I get home. My guess is that it was changed in the Steam version.

Kikithecat12345 commented 2 years ago

image @prinzstani

Looking at the object in the console, it seems it was replaced with .ddesc: image Looks like code to detect which version you are using and adjusting as such is in order.

prinzstani commented 2 years ago

OK, so in Steam .ddesc could work, which is not available in the plain version. So we can use the .ddesc if available and otherwise the .desc.

prinzstani commented 2 years ago

ddesc is available in the main version now and is used in the bot (beta for the moment).