search

prisma-labs / dripip

Opinionated CLI for continuous delivery of npm packages
100 stars 2 forks source link

Commit with only numbers appears to violate semver #135

Open skovy opened 2 years ago

skovy commented 2 years ago

Screenshot

image

Description

Commit hash with only numbers appears to violate semver. I wasn't able to confirm it was due to the numbers, but the next attempt succeeded as expected with no changes. That version was: 0.0.0-pr.7.1.f4c705a. I'm assuming it's due to the commit 0137094 being only numbers?

Repro Steps/Link

Try publishing a package with only numbers in the commit hash: 0.0.0-pr.7.1.0137094

Run yarn -s dripip preview-or-pr
    Error: The following command failed to complete successfully:

            yarn publish --tag pr.7 --no-git-tag-version --new-version 
    0.0.0-pr.7.1.0137094

        It ended with this exit code:

            1

        This underlying error occured (null = none occured):

            null

        It received signal (null = no signal received):

            null

        It output on stderr (null = not spawned in pipe mode):

            error Couldn't publish package: 
    "https://registry.yarnpkg.com/css-codemod: New versions must be valid 
    semver."

        It output on stdout (null = not spawned in pipe mode):