Organize serialization - Githubissues

privacy-scaling-explorations / halo2curves

Other

174 stars 141 forks source link

Organize serialization #177

Closed adria0 closed 2 weeks ago

adria0 commented 1 month ago

As described in #176, this PR:

Removes SerdeObject
Renames serde.rs to encoding.rs
Documents how fields can be serialized/deserialized (also fixes https://github.com/privacy-scaling-explorations/halo2curves/issues/175)

adria0 commented 1 month ago

From this comment, I think we can remove the SerdeObject from this repository. But, it should be done in the basis of implementing the from/to_mont for curve/field.

from/to_mont is already implemented for fields. Do you mean implementing them for curves? I do not see the specific use case the implement from/to_mont for curves (as also, AFAIS does not exist the concept of montgomery for curves, only for fields)

adria0 commented 2 weeks ago

Superseded by #179