search

privacy-scaling-explorations / maci

Minimal Anti-Collusion Infrastructure (MACI)
https://maci.pse.dev/
Other
533 stars 148 forks source link

restructure imt folders in the circuit package #1419

Open ctrlc03 opened 7 months ago

ctrlc03 commented 7 months ago

Restructure folders to have one file per each template

0xshikhar commented 2 months ago

Hey @ctrlc03, would love to work on this ?

ctrlc03 commented 1 month ago

Hey @ctrlc03, would love to work on this ?

sure thing, can assign you @0xshikhar thanks

crisgarner commented 1 month ago

Hey @0xshikhar, are you still working on this? want to see if we can add it to the hackthoberfest

0xshikhar commented 1 month ago

Yup, started working on this. Was quite busy due to ETHKL

0xshikhar commented 1 month ago

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

ctrlc03 commented 1 month ago

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

Hi @0xshikhar - this would be for the circuits folder not the ts code: https://github.com/privacy-scaling-explorations/maci/tree/dev/packages/circuits/circom/trees

0xshikhar commented 1 month ago

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

ctrlc03 commented 1 month ago

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

@0xshikhar I believe the original idea of this issue was to have one file for each template inside that folder. So if you open https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/circuits/circom/trees/incrementalMerkleTree.circom you can see there's different templates.