privacysandbox / protected-auction-key-value-service

Protected Auction Key/Value Service
Apache License 2.0
53 stars 20 forks source link

Custom AWS tags #36

Closed MarcoLugo closed 10 months ago

MarcoLugo commented 10 months ago

The proposed terraform works but is there an easy and preferred way to add additional tags? We use them extensively in our organization to track costs and so far we just went with a workaround that we'd prefer to avoid in the longer term. What would you recommend to add custom AWS tags?

Thank you.

lx3-g commented 10 months ago

Hi MarcoLugo, Thnx for reaching out. I'm looking into this, and will get back to you.

lx3-g commented 10 months ago

@MarcoLugo if we add a terraform variable, empty by default, of type:

variable "additional_terraform_tags" {
  type = list(object({
    name = string
    value = string
  }))
}

that will specify a list of tags that will be applied to every single aws resource that's created, would that be sufficient for your usecase?

MarcoLugo commented 10 months ago

Yes, @lx3-g , that'd be perfect. Thank you.

lx3-g commented 10 months ago

Please add any additional tags you require here: https://github.com/privacysandbox/fledge-key-value-service/blob/cb7f116a9ed5758fcc7f0148a2c2770c06790c94/production/terraform/aws/environments/main.tf#L30