search

private-attribution / ipa

A raw implementation of Interoperable Private Attribution
MIT License
42 stars 25 forks source link

Migrate IPA code to new metrics engine #1379

Closed akoshelev closed 1 month ago

akoshelev commented 1 month ago

This is the final PR to upgrade IPA to use new metric engine. This change removes the old metric dependency and updates the code to use new metrics.

This approach was tested in #1278 and the only difference here is that we don't consume metrics yet. #1353 will take care of it

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.97802% with 51 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (57e2c63) to head (69a9442). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/bin/helper.rs 5.40% 35 Missing :warning:
ipa-core/src/cli/metric_collector.rs 50.00% 12 Missing :warning:
ipa-core/src/helpers/mod.rs 88.00% 3 Missing :warning:
ipa-core/src/telemetry/step_stats.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1379 +/- ## ========================================== + Coverage 93.54% 93.63% +0.08% ========================================== Files 222 223 +1 Lines 36986 36998 +12 ========================================== + Hits 34600 34644 +44 + Misses 2386 2354 -32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.