Closed andyleiserson closed 3 weeks ago
Attention: Patch coverage is 98.74214%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 93.34%. Comparing base (
1e3a417
) to head (de1bd4b
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
ipa-core/src/protocol/ipa_prf/shuffle/mod.rs | 69.23% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This uses the
Shuffleable
trait (originally added for the semi-honest sharded shuffle) in the base shuffle and malicious shuffle code. Doing so simplifies the trait bounds on many of the shuffle routines.The bounds on
ShuffleShare
here are similar to but different fromBooleanArray
. I avoid assumingCopy
, which probably doesn't matter much for the things we shuffle currently, but makes the implementation more extensible to shuffling larger things.There are also a few other changes. Most notably, I adopt the one-side PRSS generation that was added #1187. I also eliminate some
clone
s and make some other small adjustments / simplifications.