search

probabilistic-numerics / probnum

Probabilistic Numerics in Python.
http://probnum.org
MIT License
439 stars 57 forks source link

Fix bug in `asrandvar` introduced by breaking changes in ScIPy 1.10 #763

Closed JonathanWenger closed 1 year ago

JonathanWenger commented 1 year ago

In a Nutshell

SciPy 1.10 introduced a Covariance object (see https://scipy.github.io/devdocs/release.1.10.0.html#scipy-stats-improvements), which is being used for multivariate_normal random variables. This caused a bug in the asrandvar function which is handled in this PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #763 (c8e329d) into main (30cdee3) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   90.79%   90.80%           
=======================================
  Files         210      210           
  Lines        7703     7707    +4     
  Branches      986      986           
=======================================
+ Hits         6994     6998    +4     
  Misses        478      478           
  Partials      231      231
Impacted Files Coverage Δ
src/probnum/randvars/_scipy_stats.py 72.22% <100.00%> (+1.29%) :arrow_up: