search

probabilistic-numerics / probnum

Probabilistic Numerics in Python.
http://probnum.org
MIT License
439 stars 57 forks source link

Fix matmul implementation of Zero linop #764

Closed timweiland closed 1 year ago

timweiland commented 1 year ago

In a Nutshell

matmul result now has the correct shape

Detailed Description

The Zero linear operator had a bug where in the matmul implementation, it simply returned a zero vector of the same shape of the input. But this does not always match the shape we expect from the matmul output.

Related Issues

Closes #761

codecov[bot] commented 1 year ago

Codecov Report

Merging #764 (bf5e6f1) into main (2883717) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   90.80%   90.90%   +0.10%     
==========================================
  Files         210      210              
  Lines        7707     7709       +2     
  Branches      986      984       -2     
==========================================
+ Hits         6998     7008      +10     
  Misses        478      478              
+ Partials      231      223       -8
Impacted Files Coverage Δ
src/probnum/linops/_scaling.py 87.05% <100.00%> (+4.32%) :arrow_up:
src/probnum/linops/_linear_operator.py 87.56% <0.00%> (+0.17%) :arrow_up: