probabilistic-numerics / probnum

Probabilistic Numerics in Python.
http://probnum.org
MIT License
439 stars 57 forks source link

Bugfix in `CovarianceLinearOperator` transpose #800

Closed timweiland closed 1 year ago

timweiland commented 1 year ago

In a Nutshell

Bugfix in transpose of CovarianceLinearOperator

Detailed Description

The previous _transpose implementation only worked for the case that both inputs are equal. The new implementation works for the general case where x0 and x1 may not be equal.

The new implementation now requires passing a callback keops_lazy_tensor_fn (as opposed to directly passing a LazyTensor) which the CovarianceLinearOperator can then pass on in _transpose.

codecov[bot] commented 1 year ago

Codecov Report

Merging #800 (ab3ac8b) into main (15f6d0a) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         218      218           
  Lines        8209     8210    +1     
  Branches     1060     1061    +1     
=======================================
+ Hits         7494     7495    +1     
  Misses        487      487           
  Partials      228      228           
Impacted Files Coverage Δ
.../randprocs/covfuncs/_covariance_linear_operator.py 96.42% <100.00%> (+0.13%) :arrow_up: