search

probonopd / go-appimage

Go implementation of AppImage tools
MIT License
821 stars 71 forks source link

Add `UpdateInfo` and small clean up #189

Closed mgord9518 closed 2 years ago

probonopd commented 2 years ago

Thanks @mgord9518. Is there a reason you didn't want to pull in https://github.com/AppImageCrafters/appimage-update as a dependency and rely on that implementation?

@azubieta what would be your recommendation?

mgord9518 commented 2 years ago

@probonopd Honestly there's no reason, I guess it would be a good way to kill 2 birds with 1 stone by also integrating AppImageUpdate into go-appimage. I can modify the PR if you feel it would be the better option

probonopd commented 2 years ago

Let's see what @azubieta thinks and whether https://github.com/AppImageCrafters/appimage-update will still be maintained.

azubieta commented 2 years ago

The zsync2 implementation on appimage-update is incomplete. Right now it's only capable or reusing a very limited part of the file delta and in some cases it performs worse that a regular download. It needs to be polished.

Also I haven't had any bug reports, so it's provably not being used too much. But I can take care of any bugs reported from here.

probonopd commented 2 years ago

Thanks @mgord9518. Maybe we will get to an integrated updater in go-appimage at some point in time.