probonopd / linuxdeployqt

Makes Linux applications self-contained by copying in the libraries and plugins that the application uses, and optionally generates an AppImage. Can be used for Qt and other applications
Other
2.22k stars 414 forks source link

Fix inconsistent main icon detection, closes #496 #497

Open probonopd opened 3 years ago

probonopd commented 3 years ago

I thought the exisrting code would give preference to certain icon sizes, but it turns out it didn't.

probonopd commented 3 years ago

Oopsie, it looks like Travis is broken. "Some checks haven’t completed yet". Do we need to migrate all of this to GitHub Actions?

kefir500 commented 3 years ago

Oops, didn't notice that you have already created a pull request for my commit. Just in case, the updated commit from this PR is based on the latest changes in master branch, so it should keep the Git history clean.

probonopd commented 3 years ago

Thanks @kefir500. This is blocked by https://github.com/probonopd/linuxdeployqt/issues/512.