search

processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
18 stars 92 forks source link

Fixes issue #469: storeItem value changed from any type to serializable #470

Closed SembeiNorimaki closed 1 month ago

SembeiNorimaki commented 3 months ago

storeItem value changed from any type to serializable.

Qianqianye commented 3 months ago

Thanks @SembeiNorimaki! I'm tagging the reference technical writer @nickmcintyre to take a look at this. Also, to make changes on p5.js reference, we will need to make a pull request on p5.js library repo. In this case, the documentation for storeItem() is here.

limzykenneth commented 1 month ago

As @Qianqianye for the changes to the reference to persist and not be overwritten, it needs to be updated in the inline documentation here: https://github.com/processing/p5.js/blob/main/src/data/local_storage.js#L25. I think the language can be changed but "serializable" for me is just a bit too jargon for newer users of p5.js. Being a bit more explicit around accepted types may be better.

In any case I will close this for now. Please open a relevant issue for PR to discuss this on the library repo where we can accept the changes. Thanks @SembeiNorimaki.