search

processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
18 stars 92 forks source link

Duplication of the Title in the /contribute/* pages #515

Closed computationalmama closed 2 months ago

computationalmama commented 2 months ago

Most appropriate sections of the p5.js website?

Contribute

What is your operating system?

Mac OS

Web browser and version

128.0.6613.119 (Official Build) (arm64)

Actual Behavior

The title of subpages in the /contribute/* page are duplicating.

Screenshot contribute pages in a website which shows duplication of the header Screenshot contribute pages in a website which shows duplication of the header

Expected Behavior

Should be similar to the subpages of /tutorials/*

Screenshot contribute pages in a website which doesnt show duplication of the header

Steps to reproduce

As per the screenshots above navigate to the links below to reproduce the bug:

https://p5js.org/contribute/access/ https://p5js.org/contribute/readme/

Would you like to work on the issue?

Yes

computationalmama commented 2 months ago

Resolved by:

In the src/layouts/ContributorDocLayout.astro revised code should have a subtitle={null} in the BaseLayout component.

Snippet

<BaseLayout
  title={entry.data.title}
  variant="item"
  subtitle={null}
  topic="contribute"
  className="contribute"
>

Expected Appearance

Screenshot 2024-09-08 at 6 28 29 PM
computationalmama commented 2 months ago

Woohoo! 🚀 thanks @limzykenneth