search

processone / ejabberd-contrib

Growing and curated ejabberd contributions repository - PR or ask to join !
http://ejabberd.im
250 stars 137 forks source link

mod_pubsub_serverinfo: initial version #327

Closed guusdk closed 8 months ago

guusdk commented 9 months ago

A new ejabberd module that adds support for the ProtoXEP: PubSub Server Information.

This initial version only announces support (used to 'opt-in', per the XEP). It does not publish any data. This is intended to be a future addition to this mod.

guusdk commented 9 months ago

This is a result of copy/pasting snippets from other modules. I don't have access to an ejabberd server for testing, so the changes in this PR are completely untested.

licaon-kter commented 9 months ago

Fix https://github.com/processone/ejabberd/issues/4125

guusdk commented 9 months ago

Would it be OK to approve the workflow for this PR, to get automated Github Action runs? As I have no access to an ejabberd server, the feedback from those is valuable.

~Instant-update: that appears to have been sorted while I typed this message I think. Thanks!~

guusdk commented 9 months ago

Is someone manually starting Github Actions for this PR, or do they trigger when I leave a new comment?

Instant-update: it's not triggered by comments. Someone must be pressing buttons in the background. Apologies for the noise!

badlop commented 9 months ago

Yes, I manually trigger them.

I have no access to an ejabberd server, the feedback from those is valuable.

If you have docker or podman installed, I wrote a tutorial to get ejabberd + custom modules working in few steps (no knowledge of ejabberd administration or containers required)

Neustradamus commented 9 months ago

For information, Openfire plugin and Prosody module are done.

Hope ejabberd too ^^

guusdk commented 9 months ago

The state of the code as-is should be usable to advertise support for the XEP. That's the bare minimum required for servers to signal that they're OK with being named by other servers.

It is not within my capabilities to implement the remaining functionality: publication of data about the server that has this module installed. Hopefully, someone else can contribute that implementation.

Kindly consider publishing the module as-is, without closing the ticket.

prefiks commented 8 months ago

Let's merge this as is, as i understand optionally server could also present some information about s2s connections that it have in this?

guusdk commented 8 months ago

Thanks!

The code as-is will only flag that the server on which the module is installed supports a feature. (This will allow other servers to include this server as a named entity in their data).

To-do: this module should publish data about its own server-to-server connections to a pub/sub node.

Neustradamus commented 5 months ago

There is now a XEP number: XEP-0485: PubSub Server Information