search

procore-oss / backstage-plugin-announcements

Announcements Plugin for Backstage
https://procore-oss.github.io/backstage-plugin-announcements/
MIT License
27 stars 20 forks source link

🚀 Feature: Improve readability in AnnouncementBanner #275

Open ivangonzalezacuna opened 6 months ago

ivangonzalezacuna commented 6 months ago

🔖 Feature description

We are using the announcements plugin for a while. Some of our developer have suggested that the banner colors are not the best regarding readability, specially in the light mode. We've seen this PR in the past: https://github.com/K-Phoen/backstage-plugin-announcements/pull/154, but it wasn't merged there, and doesn't seem to be here either. Is this something that would make sense?

🎤 Context

Some of our developer have complained about some readability issues in the banners, specially in the light theme.

✌️ Possible Implementation

As mentioned above, a solution like the one described in https://github.com/K-Phoen/backstage-plugin-announcements/pull/154 could be a nice one.

👀 Have you spent some time to check if this feature request has been raised before?

Are you willing to submit PR?

None

kurtaking commented 5 months ago

hey @ivangonzalezacuna, thanks for reaching out. I posted on that issue in the past.

Happy to review a PR if you would like to contribute the functionality.

kurtaking commented 5 months ago

Maybe that is something @sravanireddy115 can help with?

ivangonzalezacuna commented 5 months ago

hey @ivangonzalezacuna, thanks for reaching out. I https://github.com/K-Phoen/backstage-plugin-announcements/pull/154#issuecomment-1792715436 in the past. Happy to review a PR if you would like to contribute the functionality.

Hi! Unfortunately I don't have much time to try that out at the moment, so it would be nice if somebody else has some time to check this out. I guess some of the work can be easily done by the suggestion in that issue, but I'm not entirely sure.

jmezach commented 3 weeks ago

Just a thought here, but would it make sense to replace the banner entirely in favour of the new Notifications support in Backstage itself?

kurtaking commented 3 days ago

Just a thought here, but would it make sense to replace the banner entirely in favour of the new Notifications support in Backstage itself?

@jmezach, its very likely the notifications plugin could replace announcements altogether.