search

procore-oss / backstage-plugin-announcements

Announcements Plugin for Backstage
https://procore-oss.github.io/backstage-plugin-announcements/
MIT License
29 stars 23 forks source link

[ON HOLD]: Migrating announcements plugins to `@backstage-community/plugins` repository #373

Open kurtaking opened 4 months ago

kurtaking commented 4 months ago

The announcement plugins should be migrated to backstage/community-plugins. When we first took these over, that repository didn't exist, and the main repo no longer allowed new plugins. If it had, I would have migrated them there and volunteered to be a maintainer. The biggest benefit from migrating is the chance for additional maintainers passionate about the plugins to have more ownership.

My rough draft plan would be to

  1. Update plugins to the latest version of backstage
  2. Resolve any outstanding Issues
  3. Migrate plugins
  4. Redirect feature requests to backstage/community-plugins

Thoughts and comments?

kurtaking commented 4 months ago

@gaelgoth wanted to make sure you saw this as you come to mind when I think of additional maintainers.

gaelgoth commented 4 months ago

It makes sense to move the community repository. I would be happy to help and contribute as a maintainer

kurtaking commented 3 months ago

I've started this process here - https://github.com/backstage/community-plugins/pull/880

awanlin commented 3 months ago

Hi @kurtaking, I saw that the PR you submitted is closed, is the plan to move this still?

kurtaking commented 3 months ago

Hi @kurtaking, I saw that the PR you submitted is closed, is the plan to move this still?

hey @awanlin, yes, that is the plan, but I have struggled to find the time to do so.

awanlin commented 3 months ago

Thanks for the update @kurtaking, just wasn't sure if plans had changed once I saw the PR was closed. 👍

kurtaking commented 3 months ago

Thanks for the update @kurtaking, just wasn't sure if plans had changed once I saw the PR was closed. 👍

First-time father with a 3-month-old is taking up all of my free time. 😄 On the flip side, that's also why I need to get it done. So others aren't affected by my absence.

kurtaking commented 3 months ago

Here is the new PR for migration.

matdtr commented 2 weeks ago

Hi,

I saw https://github.com/backstage/community-plugins/pull/1637, it went stale due to the migration being still on hold? Or PR should be reopened by backstage maintainers? Would like to add this plugin to my instance.

thanks

awanlin commented 1 week ago

I'm happy to reopen it, odd that it never got assigned to anyone when it was created. The challenge is two fold:

  1. On our side - Community Plugin Maintainers - this is a massive PR of 150 files to review, as there won't be proper ownership for it, meaning it wall fall to use to review all changes, we need to make sure everything follows the proper conventions.
  2. On the Procore side we need someone to help follow up on comments.
kurtaking commented 6 days ago

I'm happy to reopen it, odd that it never got assigned to anyone when it was created. The challenge is two fold:

  1. On our side - Community Plugin Maintainers - this is a massive PR of 150 files to review, as there won't be proper ownership for it, meaning it wall fall to use to review all changes, we need to make sure everything follows the proper conventions.

  2. On the Procore side we need someone to help follow up on comments.

I continue to struggle to find time to take care of this. I agree the PR gets too large too quickly, and twice I have given up due to being overwhelmed.

I was thinking maybe we move one plugin at a time to narrow the scope of each PR?

I want it to live in the community repo where I'd like to continue to be a maintainer with hopefully some additional support 🙏🏼 . Our direction internally hasn't fully utilized announcements like we originally intended, and it's hard to give the plugins the attention they need when we aren't actively adding feature enhancements.