search

procore-oss / blueprinter

Simple, Fast, and Declarative Serialization Library for Ruby
MIT License
1.14k stars 109 forks source link

Deprecate DateTimeFormatter #406

Open sandstrom opened 8 months ago

sandstrom commented 8 months ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

This logic could easily be implemented using an extractor, with a simple example in the readme.

Describe the feature you'd like to see implemented

I'd deprecate DateTimeFormatter and instead add a readme example on how to implement this using an extractor. The added logic doesn't seem worth the extra complexity.

Describe alternatives you've considered

Do nothing 😄

Additional context

No response

sandstrom commented 8 months ago

Happy to discuss this in more detail, and elaborate more.

sandstrom commented 7 months ago

Friendly ping @lessthanjacob @njbbaer @ritikesh

Happy to hear your thoughts on this!

ritikesh commented 7 months ago

That's the eventual plan. I think I had hinted at that in one of the earlier PRs too. Pls feel free to make a contribution!

lessthanjacob commented 5 months ago

Relevant discussion #420

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sandstrom commented 3 months ago

Not stale

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sandstrom commented 1 month ago

Not stale