profanity-im / profanity

Ncurses based XMPP client
https://profanity-im.github.io/
Other
1.33k stars 188 forks source link

Wrong error about server not supporting MAM. #1940

Closed mdosch closed 11 months ago

mdosch commented 11 months ago

On startup profanity shows the error Server doesn't support MAM (urn:xmpp:mam:2). although the server supports MAM.

Expected Behavior

It should only show that error if the server really doesn't support MAM.

Current Behavior

On startup profanity shows the error Server doesn't support MAM (urn:xmpp:mam:2). although the server supports MAM.

Steps to Reproduce (for bugs)

  1. Start profanity and check messages in console window. (Don't know if this only happens in my set up or in general)

Environment

profanity --version
Profanity, version 0.14.0dev.master.0e66cbe4
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2023 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons/clipboard: Disabled
GDK Pixbuf: Enabled
sjaeckel commented 11 months ago

Did you try the patch I shared? Does it happen for you on first connect as well or only on reconnect? Going to open a PR with it when I have the time, maybe still today.

mdosch commented 11 months ago

Yes, the patch worked. Just created the issue to assure it's not getting forgotten.