profunktor / fs2-rabbit

:rabbit: RabbitMQ stream-based client built on top of Fs2
https://fs2-rabbit.profunktor.dev/
Apache License 2.0
149 stars 44 forks source link

CI/CD: Add a scalafmt check to github actions #1004

Closed matejcerny closed 3 weeks ago

matejcerny commented 3 weeks ago

To prevent errors with Sonatype release, add a scalafmtAll step to github actions.

geirolz commented 3 weeks ago

Do we want a step that fails if the code isn't properly formatted ? Because scalafmtAll implies a commit

matejcerny commented 3 weeks ago

Sorry, you are right, it should be scalafmtCheckAll. Imho it's better to fail the whole pipeline rather than examine why the release does not work.