search

profunktor / fs2-rabbit

:rabbit: RabbitMQ stream-based client built on top of Fs2
https://fs2-rabbit.profunktor.dev/
Apache License 2.0
149 stars 44 forks source link

Added automaticTopologyRecovery to Fs2RabbitConfig #972

Closed SheliakLyr closed 2 months ago

SheliakLyr commented 2 months ago

TopologyRecovery feature in amqp-client is sometimes strange. I prefer to have it disabled. This PR adds the needed configuration option to Fs2RabbitConfig.

This change is not backwards compatible in Fs2RabbitConfig constructor. It is not possible to add a default - only one apply method can have defaults defined. I could try to add some additional methods to keep compability.

Also, I fixed a small compilation error (unrelated).

geirolz commented 2 months ago

This change is not backwards compatible in Fs2RabbitConfig constructor

This isn't a problem I'd say

geirolz commented 2 months ago

P.S. Ignore the CI error, there is a PR to fix it and it isn't related to your changes https://github.com/profunktor/fs2-rabbit/pull/973