progmaticltd / homebox

A set of ansible scripts to build a personal mail server / private cloud / etc.
https://homebox.space/
GNU General Public License v3.0
461 stars 52 forks source link

GitHub branch permissions #339

Closed progmaticltd closed 4 years ago

progmaticltd commented 4 years ago

Hello, @sorcer1122,

I just realised you committed something, so thanks a lot for this, it is a good one, btw.

I initially configured the branch permissions, on github, using a regular expression (dev|master), and I realised today that you pushed directly to the dev branch, so the rule clearly does not accept regex patterns.

It is probably my fault too, I should have checked myself :-D

Anyway, here the process to do normally, as @fredericmoulins and myself are doing:

Thanks for the commit, though. I am happy to share the expertise in running unit tests locally.

@sorcer1122, You you have read this, just close the bug report, I don't knew how to contact you!