Closed fgrehm closed 9 years ago
This is really great. Because the project is so young and I have really high bash standards, I might refactor this before merging. But as such it might sit for a bit because I need to get back to some existing projects.
No problemo!
@progrium are you still interested in any of this? if you are I can try bringing this up to speed with master and squashing some commits.
I'm already having trouble modeling some of this in bash cleanly so I'm planning to start porting most of enterenv to go. So thanks for the PoC but this PR isn't going to make it.
On Monday, July 6, 2015, Fabio Rehm notifications@github.com wrote:
@progrium https://github.com/progrium are you still interested in any of this? if you are I can try bringing this up to speed with master and squashing some commits.
— Reply to this email directly or view it on GitHub https://github.com/progrium/envy/pull/25#issuecomment-118852604.
Jeff Lindsay http://progrium.com
no worries!
This provides just a little bit cleanup that I think will make other people lives easier and it should be able to close GH-16 and GH-14.
The part where it checks for the throwaway environment is a bit messed up but it is the best I could do with my current bash knowledge. I'm happy to refactor it if anyone knows a better way of doing that :blush:
Sorry for doing too much in a single PR, I'm cool to extract them into smaller ones :grin: