Bonemeal grows crops without consuming the ItemStack

BunnyCinnamon commented 5 years ago

Hellooo!!

When Serene Seasons and Hunger Overhaul are present, and a crop wich is not in its fertile season is right clicked with bonemeal, said crop will grow, and the bonemeal stack won't be consumed.

Version Information

Minecraft: 1.12.2 Forge: 14.23.5.2795 Apple Core: 1.12.2-3.1.4 Hunger Overhaul: 1.12.2-1.3.3 Serene Seasons: 1.12.2-1.2.13 Pam's Harvestcraft: 1.12.2za

Report Information

During the event "BonemealModule.onBonemealUsed" when modifyBonemealGrowth is set to true in the configuration file, mods that might cancel the event after the method fires are not taken into account; This leads to a bug when paired with Serene Seasons, that messes with the BonemealEvent right after Hunger Overhaul's.

Steps to Reproduce

Step one: Create a farmland block

Step two: Plant a crop that is not fertile in the current season, for example Black Berry (Autumn) in Summer.

Step three: Bonemeal the crop multiple times utilizing the player's main hand

Events Log

Link to pastebin

IdrisQe commented 5 years ago

It'd be nice to get a fix for this sometime soon. I just encountered the bug too, and it's rather annoying. It seems to occur with ANY bonemeal-like item, such as the eggshells from Exotic Birds, as well.

Kehaan commented 4 years ago

Just wanted to say i am also getting this issue with those 2 mods :) However setting "modifyBonemealGrowth" to false solves the issue.

progwml6 / HungerOverhaul