project-asgard / asgard

MIT License
27 stars 20 forks source link

MacOS precision matrix #738

Open quantumsteve opened 1 week ago

quantumsteve commented 1 week ago

Please review the developer documentation on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here with a supported keyword.

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

Does this introduce a breaking change?

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

quantumsteve commented 1 week ago

@stefan-schnake @mkstoyanov The errors in some of these tests look quite large.

-------------------------------------------------------------------------------
time advance - continuity 6 - float
  continuity6, level 2, degree 2, sparse grid
-------------------------------------------------------------------------------
/Users/runner/work/asgard/asgard/src/asgard_time_advance_tests.cpp:420
...............................................................................

/Users/runner/work/asgard/asgard/testing/tests_general.hpp:78: FAILED:
  REQUIRE( (diff_norm / max) < (tolerance * std::sqrt(v0.size())) )
with expansion:
  1.81565344333648681641f < 0.000187678